From 451f83467666ae0a56fd930957e83b24c030bb83 Mon Sep 17 00:00:00 2001 From: stratospher <44024636+stratospher@users.noreply.github.com> Date: Thu, 16 Jan 2025 17:00:58 +0530 Subject: [PATCH] validation: remove BLOCK_FAILED_MASK since it's the same as BLOCK_FAILED_VALID now --- src/chain.h | 5 ++--- src/node/blockstorage.cpp | 2 +- src/rpc/blockchain.cpp | 2 +- src/rpc/mining.cpp | 2 +- src/test/blockchain_tests.cpp | 2 +- src/test/fuzz/chain.cpp | 1 - src/validation.cpp | 28 ++++++++++++++-------------- 7 files changed, 20 insertions(+), 22 deletions(-) diff --git a/src/chain.h b/src/chain.h index 5810dcec107..87938d3710e 100644 --- a/src/chain.h +++ b/src/chain.h @@ -124,7 +124,6 @@ enum BlockStatus : uint32_t { BLOCK_FAILED_VALID = 32, //!< stage after last reached validness failed BLOCK_FAILED_CHILD = 64, //!< Unused flag that was previously set when descending from failed block - BLOCK_FAILED_MASK = BLOCK_FAILED_VALID | BLOCK_FAILED_CHILD, BLOCK_OPT_WITNESS = 128, //!< block data in blk*.dat was received with a witness-enforcing client @@ -297,7 +296,7 @@ public: { AssertLockHeld(::cs_main); assert(!(nUpTo & ~BLOCK_VALID_MASK)); // Only validity flags allowed. - if (nStatus & BLOCK_FAILED_MASK) + if (nStatus & BLOCK_FAILED_VALID) return false; return ((nStatus & BLOCK_VALID_MASK) >= nUpTo); } @@ -308,7 +307,7 @@ public: { AssertLockHeld(::cs_main); assert(!(nUpTo & ~BLOCK_VALID_MASK)); // Only validity flags allowed. - if (nStatus & BLOCK_FAILED_MASK) return false; + if (nStatus & BLOCK_FAILED_VALID) return false; if ((nStatus & BLOCK_VALID_MASK) < nUpTo) { nStatus = (nStatus & ~BLOCK_VALID_MASK) | nUpTo; diff --git a/src/node/blockstorage.cpp b/src/node/blockstorage.cpp index 490ba0609ec..ecc061a7d98 100644 --- a/src/node/blockstorage.cpp +++ b/src/node/blockstorage.cpp @@ -463,7 +463,7 @@ bool BlockManager::LoadBlockIndex(const std::optional& snapshot_blockha pindex->m_chain_tx_count = pindex->nTx; } } - if (!(pindex->nStatus & BLOCK_FAILED_MASK) && pindex->pprev && (pindex->pprev->nStatus & BLOCK_FAILED_MASK)) { + if (!(pindex->nStatus & BLOCK_FAILED_VALID) && pindex->pprev && (pindex->pprev->nStatus & BLOCK_FAILED_VALID)) { pindex->nStatus |= BLOCK_FAILED_VALID; m_dirty_blockindex.insert(pindex); } diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp index ca872cf6ac8..aa40faa7753 100644 --- a/src/rpc/blockchain.cpp +++ b/src/rpc/blockchain.cpp @@ -1558,7 +1558,7 @@ static RPCHelpMan getchaintips() if (active_chain.Contains(block)) { // This block is part of the currently active chain. status = "active"; - } else if (block->nStatus & BLOCK_FAILED_MASK) { + } else if (block->nStatus & BLOCK_FAILED_VALID) { // This block or one of its ancestors is invalid. status = "invalid"; } else if (!block->HaveNumChainTxs()) { diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp index f11305f16b8..cee92f72889 100644 --- a/src/rpc/mining.cpp +++ b/src/rpc/mining.cpp @@ -739,7 +739,7 @@ static RPCHelpMan getblocktemplate() if (pindex) { if (pindex->IsValid(BLOCK_VALID_SCRIPTS)) return "duplicate"; - if (pindex->nStatus & BLOCK_FAILED_MASK) + if (pindex->nStatus & BLOCK_FAILED_VALID) return "duplicate-invalid"; return "duplicate-inconclusive"; } diff --git a/src/test/blockchain_tests.cpp b/src/test/blockchain_tests.cpp index a38d41374ef..0f8ac3c4424 100644 --- a/src/test/blockchain_tests.cpp +++ b/src/test/blockchain_tests.cpp @@ -135,7 +135,7 @@ BOOST_FIXTURE_TEST_CASE(invalidate_block, TestChain100Setup) auto pindex = tip_to_invalidate->pprev; while (pindex) { WITH_LOCK(::cs_main, assert(pindex->IsValid(BLOCK_VALID_TRANSACTIONS))); - WITH_LOCK(::cs_main, assert((pindex->nStatus & BLOCK_FAILED_MASK) == 0)); + WITH_LOCK(::cs_main, assert((pindex->nStatus & BLOCK_FAILED_VALID) == 0)); pindex = pindex->pprev; } diff --git a/src/test/fuzz/chain.cpp b/src/test/fuzz/chain.cpp index 5e9be6bc8ce..1b347aee8e4 100644 --- a/src/test/fuzz/chain.cpp +++ b/src/test/fuzz/chain.cpp @@ -50,7 +50,6 @@ FUZZ_TARGET(chain) BlockStatus::BLOCK_HAVE_UNDO, BlockStatus::BLOCK_HAVE_MASK, BlockStatus::BLOCK_FAILED_VALID, - BlockStatus::BLOCK_FAILED_MASK, BlockStatus::BLOCK_OPT_WITNESS, }); if (block_status & ~BLOCK_VALID_MASK) { diff --git a/src/validation.cpp b/src/validation.cpp index 61bad4e4df8..074e489f964 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -3274,7 +3274,7 @@ CBlockIndex* Chainstate::FindMostWorkChain() // which block files have been deleted. Remove those as candidates // for the most work chain if we come across them; we can't switch // to a chain unless we have all the non-active-chain parent blocks. - bool fFailedChain = pindexTest->nStatus & BLOCK_FAILED_MASK; + bool fFailedChain = pindexTest->nStatus & BLOCK_FAILED_VALID; bool fMissingData = !(pindexTest->nStatus & BLOCK_HAVE_DATA); if (fFailedChain || fMissingData) { // Candidate chain is not usable (either invalid or missing data) @@ -3682,7 +3682,7 @@ bool Chainstate::InvalidateBlock(BlockValidationState& state, CBlockIndex* pinde // at least as good with CBlockIndexWorkComparator as the new tip. if (!m_chain.Contains(candidate) && !CBlockIndexWorkComparator()(candidate, pindex->pprev) && - !(candidate->nStatus & BLOCK_FAILED_MASK)) { + !(candidate->nStatus & BLOCK_FAILED_VALID)) { highpow_outofchain_headers.insert({candidate->nChainWork, candidate}); } } @@ -3777,7 +3777,7 @@ bool Chainstate::InvalidateBlock(BlockValidationState& state, CBlockIndex* pinde } // Mark pindex as invalid if it never was in the main chain - if (!pindex_was_in_chain && !(pindex->nStatus & BLOCK_FAILED_MASK)) { + if (!pindex_was_in_chain && !(pindex->nStatus & BLOCK_FAILED_VALID)) { pindex->nStatus |= BLOCK_FAILED_VALID; m_blockman.m_dirty_blockindex.insert(pindex); setBlockIndexCandidates.erase(pindex); @@ -3841,8 +3841,8 @@ void Chainstate::ResetBlockFailureFlags(CBlockIndex *pindex) { // Remove the invalidity flag from this block and all its descendants and ancestors. for (auto& [_, block_index] : m_blockman.m_block_index) { - if ((block_index.nStatus & BLOCK_FAILED_MASK) && (block_index.GetAncestor(nHeight) == pindex || pindex->GetAncestor(block_index.nHeight) == &block_index)) { - block_index.nStatus &= ~BLOCK_FAILED_MASK; + if ((block_index.nStatus & BLOCK_FAILED_VALID) && (block_index.GetAncestor(nHeight) == pindex || pindex->GetAncestor(block_index.nHeight) == &block_index)) { + block_index.nStatus &= ~BLOCK_FAILED_VALID; m_blockman.m_dirty_blockindex.insert(&block_index); if (block_index.IsValid(BLOCK_VALID_TRANSACTIONS) && block_index.HaveNumChainTxs() && setBlockIndexCandidates.value_comp()(m_chain.Tip(), &block_index)) { setBlockIndexCandidates.insert(&block_index); @@ -4319,7 +4319,7 @@ bool ChainstateManager::AcceptBlockHeader(const CBlockHeader& block, BlockValida CBlockIndex* pindex = &(miSelf->second); if (ppindex) *ppindex = pindex; - if (pindex->nStatus & BLOCK_FAILED_MASK) { + if (pindex->nStatus & BLOCK_FAILED_VALID) { LogDebug(BCLog::VALIDATION, "%s: block %s is marked invalid\n", __func__, hash.ToString()); return state.Invalid(BlockValidationResult::BLOCK_CACHED_INVALID, "duplicate-invalid"); } @@ -4339,7 +4339,7 @@ bool ChainstateManager::AcceptBlockHeader(const CBlockHeader& block, BlockValida return state.Invalid(BlockValidationResult::BLOCK_MISSING_PREV, "prev-blk-not-found"); } pindexPrev = &((*mi).second); - if (pindexPrev->nStatus & BLOCK_FAILED_MASK) { + if (pindexPrev->nStatus & BLOCK_FAILED_VALID) { LogDebug(BCLog::VALIDATION, "header %s has prev block invalid: %s\n", hash.ToString(), block.hashPrevBlock.ToString()); return state.Invalid(BlockValidationResult::BLOCK_INVALID_PREV, "bad-prevblk"); } @@ -5004,7 +5004,7 @@ bool ChainstateManager::LoadBlockIndex() chainstate->TryAddBlockIndexCandidate(pindex); } } - if (pindex->nStatus & BLOCK_FAILED_MASK && (!m_best_invalid || pindex->nChainWork > m_best_invalid->nChainWork)) { + if (pindex->nStatus & BLOCK_FAILED_VALID && (!m_best_invalid || pindex->nChainWork > m_best_invalid->nChainWork)) { m_best_invalid = pindex; } if (pindex->IsValid(BLOCK_VALID_TREE) && (m_best_header == nullptr || CBlockIndexWorkComparator()(m_best_header, pindex))) @@ -5252,7 +5252,7 @@ void ChainstateManager::CheckBlockIndex() const // are not yet validated. CChain best_hdr_chain; assert(m_best_header); - assert(!(m_best_header->nStatus & BLOCK_FAILED_MASK)); + assert(!(m_best_header->nStatus & BLOCK_FAILED_VALID)); best_hdr_chain.SetTip(*m_best_header); std::multimap forward; @@ -5365,9 +5365,9 @@ void ChainstateManager::CheckBlockIndex() const if ((pindex->nStatus & BLOCK_VALID_MASK) >= BLOCK_VALID_SCRIPTS) assert(pindexFirstNotScriptsValid == nullptr); // SCRIPTS valid implies all parents are SCRIPTS valid if (pindexFirstInvalid == nullptr) { // Checks for not-invalid blocks. - assert((pindex->nStatus & BLOCK_FAILED_MASK) == 0); // The failed mask cannot be set for blocks without invalid parents. + assert((pindex->nStatus & BLOCK_FAILED_VALID) == 0); // The failed flag cannot be set for blocks without invalid parents. } else { - assert(pindex->nStatus & BLOCK_FAILED_MASK); // Invalid blocks and their descendants must be marked as invalid + assert(pindex->nStatus & BLOCK_FAILED_VALID); // Invalid blocks and their descendants must be marked as invalid } // Make sure m_chain_tx_count sum is correctly computed. if (!pindex->pprev) { @@ -5382,7 +5382,7 @@ void ChainstateManager::CheckBlockIndex() const assert((pindex->m_chain_tx_count != 0) == (pindex == snap_base)); } // There should be no block with more work than m_best_header, unless it's known to be invalid - assert((pindex->nStatus & BLOCK_FAILED_MASK) || pindex->nChainWork <= m_best_header->nChainWork); + assert((pindex->nStatus & BLOCK_FAILED_VALID) || pindex->nChainWork <= m_best_header->nChainWork); // Chainstate-specific checks on setBlockIndexCandidates for (const Chainstate* c : {m_ibd_chainstate.get(), m_snapshot_chainstate.get()}) { @@ -5726,7 +5726,7 @@ util::Result ChainstateManager::ActivateSnapshot( base_blockhash.ToString()))}; } - bool start_block_invalid = snapshot_start_block->nStatus & BLOCK_FAILED_MASK; + bool start_block_invalid = snapshot_start_block->nStatus & BLOCK_FAILED_VALID; if (start_block_invalid) { return util::Error{Untranslated(strprintf("The base block header (%s) is part of an invalid chain", base_blockhash.ToString()))}; } @@ -6439,7 +6439,7 @@ void ChainstateManager::RecalculateBestHeader() AssertLockHeld(cs_main); m_best_header = ActiveChain().Tip(); for (auto& entry : m_blockman.m_block_index) { - if (!(entry.second.nStatus & BLOCK_FAILED_MASK) && m_best_header->nChainWork < entry.second.nChainWork) { + if (!(entry.second.nStatus & BLOCK_FAILED_VALID) && m_best_header->nChainWork < entry.second.nChainWork) { m_best_header = &entry.second; } }