From b371761b52c781be3cccbd9902a6d8b70504f12e Mon Sep 17 00:00:00 2001 From: fanquake Date: Wed, 17 Sep 2025 10:26:12 +0100 Subject: [PATCH 1/2] ci: re-add Valgrind job to the CI --- .github/workflows/ci.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f5a6f9ab90f..0500e4284a6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -507,6 +507,12 @@ jobs: timeout-minutes: 120 file-env: './ci/test/00_setup_env_native_centos.sh' + - name: 'Valgrind' + cirrus-runner: 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-lg' + fallback-runner: 'ubuntu-24.04' + timeout-minutes: 120 + file-env: './ci/test/00_setup_env_native_valgrind.sh' + - name: 'tidy' cirrus-runner: 'ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-md' fallback-runner: 'ubuntu-24.04' From b9b1947b81b8a84907e0cbe17bf32cd37a1d31f8 Mon Sep 17 00:00:00 2001 From: fanquake Date: Wed, 17 Sep 2025 11:24:09 +0100 Subject: [PATCH 2/2] ci: exclude wallet_miniscript from valgrind ci It runs ~4x slower than the next slowest job (~2086s), `tool_signet_miner.py ` (~536s) which greatly increases the job runtime. --- ci/test/00_setup_env_native_valgrind.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/test/00_setup_env_native_valgrind.sh b/ci/test/00_setup_env_native_valgrind.sh index d6c45755df2..e3d0fdc9fc3 100755 --- a/ci/test/00_setup_env_native_valgrind.sh +++ b/ci/test/00_setup_env_native_valgrind.sh @@ -13,7 +13,7 @@ export PIP_PACKAGES="--break-system-packages pycapnp" export USE_VALGRIND=1 export NO_DEPENDS=1 # bind tests excluded for now, see https://github.com/bitcoin/bitcoin/issues/17765#issuecomment-602068547 -export TEST_RUNNER_EXTRA="--exclude rpc_bind,feature_bind_extra" +export TEST_RUNNER_EXTRA="--exclude rpc_bind,feature_bind_extra,wallet_miniscript" export GOAL="install" # TODO enable GUI export BITCOIN_CONFIG="\