laantungir
/
bitcoin
mirror of https://github.com/bitcoin/bitcoin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: check LoadBlockIndex correctly recomputes invalidity flags 

Add a test for block index transitioning from legacy
BLOCK_FAILED_CHILD to BLOCK_FAILED_VALID behavior.

In the scenario where a valid block has a BLOCK_FAILED_CHILD
parent and a BLOCK_FAILED_VALID grandparent, ensure that all
three blocks are correctly marked as BLOCK_FAILED_VALID
after reloading the block index.
This commit is contained in:
stratospher 2025-10-08 15:23:53 +05:30
parent 87833a18ed
commit cfadc8038c
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/test/blockchain_tests.cpp
View File

@ -124,6 +124,11 @@ BOOST_FIXTURE_TEST_CASE(invalidate_block, TestChain100Setup)
// Check BlockStatus when doing InvalidateBlock()
BlockValidationState state;
auto* orig_tip = active.Tip();
CBlockIndex* block_100 = active[100];
CBlockIndex* block_99 = active[99];
CBlockIndex* block_98 = active[98];
int height_to_invalidate = orig_tip->nHeight - 10;
auto* tip_to_invalidate = active[height_to_invalidate];
m_node.chainman->ActiveChainstate().InvalidateBlock(state, tip_to_invalidate);
@ -145,6 +150,26 @@ BOOST_FIXTURE_TEST_CASE(invalidate_block, TestChain100Setup)
WITH_LOCK(::cs_main, assert(pindex->nStatus & BLOCK_FAILED_VALID));
pindex = pindex->pprev;
}
{
// consider the chain of blocks block_98 <- block_99 <- block_100
// intentionally mark:
// - block_98: BLOCK_FAILED_VALID (already marked as BLOCK_FAILED_VALID from previous test)
// - block_99: BLOCK_FAILED_CHILD (clear BLOCK_FAILED_VALID from previous test and mark as BLOCK_FAILED_CHILD)
// - block_100: not invalid (clear BLOCK_FAILED_VALID from previous test)
LOCK(::cs_main);
assert(block_98->nStatus & BLOCK_FAILED_VALID);
block_99->nStatus = (block_99->nStatus & ~BLOCK_FAILED_VALID) | BLOCK_FAILED_CHILD;
block_100->nStatus = (block_100->nStatus & ~BLOCK_FAILED_VALID);
// Reload block index to recompute block status validity flags from disk.
m_node.chainman->LoadBlockIndex();
// check block_98, block_99, block_100 is marked as BLOCK_FAILED_VALID after reloading from disk
assert(block_98->nStatus & BLOCK_FAILED_VALID);
assert(block_99->nStatus & BLOCK_FAILED_VALID);
assert(block_100->nStatus & BLOCK_FAILED_VALID);
}
}
BOOST_AUTO_TEST_SUITE_END()