From fac00d4ed361e5e8c8989b2bb5a4a22dd54e2c72 Mon Sep 17 00:00:00 2001 From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> Date: Tue, 20 May 2025 19:02:22 +0200 Subject: [PATCH] doc: Move CI-must-pass requirement into readme section Seems fine to state it clearly once. --- README.md | 4 ++-- doc/developer-notes.md | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 6628e0a5c98..7e524461c50 100644 --- a/README.md +++ b/README.md @@ -56,8 +56,8 @@ in Python. These tests can be run (if the [test dependencies](/test) are installed) with: `build/test/functional/test_runner.py` (assuming `build` is your build directory). -The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, -and that unit/sanity tests are run automatically. +The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. +The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests. ### Manual Quality Assurance (QA) Testing diff --git a/doc/developer-notes.md b/doc/developer-notes.md index ce6ea7e0596..27bcd20d003 100644 --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -799,12 +799,6 @@ General Bitcoin Core - *Rationale*: RPC allows for better automatic testing. The test suite for the GUI is very limited. -- Make sure pull requests pass CI before merging. - - - *Rationale*: Makes sure that they pass thorough testing, and that the tester will keep passing - on the master branch. Otherwise, all new pull requests will start failing the tests, resulting in - confusion and mayhem. - Logging -------