laantungir
/
bitcoin
mirror of https://github.com/bitcoin/bitcoin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
bitcoin/cmake
History
merge-script 6e5b67a370
Merge bitcoin/bitcoin#32697: test: Turn util/test_runner into functional test 
fa21631595 test: Use self.log (MarcoFalke)
fa346f7797 test: Move error string into exception (MarcoFalke)
fa1986181f test: Remove useless catch-throw (MarcoFalke)
fa2f1c55b7 move-only util data to test/functional/data/util (MarcoFalke)
faa18bf287 test: Turn util/test_runner into functional test (MarcoFalke)
fa955154c7 test: Add missing skip_if_no_bitcoin_tx (MarcoFalke)
fac9db6eb0 test: Add missing tx util to Binaries (MarcoFalke)
fa91835ec6 test: Use lowercase env var as attribute name (MarcoFalke)
fac49094cd test: Remove duplicate ConfigParser (MarcoFalke)

Pull request description:

  The `test/util/test_runner.py` has many issues:

  * The boilerplate for the test runner is duplicate or inconsistent with the other (functional) tests. For example, logging options, `ConfigParser` handling, `Binaries` handling ...
  * The cmake/ci behavior is brittle and can silently fail, as explained in https://github.com/bitcoin/bitcoin/issues/31476
  * corecheck (and likely other places that manually run the tests) completely forget to run it
  * If the test is manually called, it runs single threaded, when it could just run in parallel with the other functional tests

  Fix all issues by removing the util test_runner and moving the test logic into a new functional test file.

ACKs for top commit:
  janb84:
    re ACK fa21631595
  brunoerg:
    re-ACK fa21631595
  hebasto:
    re-ACK fa21631595, additional feedback has been addressed since my previous [review](https://github.com/bitcoin/bitcoin/pull/32697#pullrequestreview-2940350432).

Tree-SHA512: 694e647887801f002843a74011035d5ed3dfed091d3f0ae18e812a16a4680e04e60e50de0a92af7e047e8ddd6ff5a7834c690f16fd42b74ebc1674bf9989406f
 		2025-06-30 13:45:14 -04:00
..
module build: Find Boost in config mode 2025-06-26 16:49:24 +01:00
script cmake: Copy `cov_tool_wrapper.sh.in` to the build tree 2025-01-23 10:00:58 +00:00
bitcoin-build-config.h.in cmake: Remove `ENABLE_ARM_SHANI` from `bitcoin-build-config.h` 2025-05-20 11:14:17 +01:00
ccache.cmake build: don't use ccache with MSVC 2025-03-04 14:53:06 +00:00
crc32c.cmake Merge bitcoin/bitcoin#31662: cmake: Do not modify `CMAKE_TRY_COMPILE_TARGET_TYPE` globally 2025-02-20 15:07:03 -05:00
introspection.cmake Merge bitcoin/bitcoin#32460: fs: remove `_POSIX_C_SOURCE` defining 2025-05-30 10:21:01 +01:00
leveldb.cmake build: remove Wsuggest-override suppression from leveldb build 2025-05-16 16:08:40 +01:00
libmultiprocess.cmake cmake: Fix clang-tidy "no input files" errors 2025-04-02 08:41:16 -05:00
minisketch.cmake Merge bitcoin/bitcoin#31880: cmake: Add optional sources to `minisketch` library directly 2025-02-25 14:11:58 -05:00
tests.cmake test: Turn util/test_runner into functional test 2025-06-13 13:06:59 +02:00
windows-app.manifest.in cmake: Add application manifests when cross-compiling for Windows 2025-05-15 13:57:57 +01:00