bitcoin/src/wallet
merge-script fad009af49
Merge bitcoin/bitcoin#32520: Remove legacy `Parse(U)Int*`
faf55fc80b doc: Remove ParseInt mentions in documentation (MarcoFalke)
3333282933 refactor: Remove unused Parse(U)Int* (MarcoFalke)
fa84e6c36c bitcoin-tx: Reject + sign in MutateTxDel* (MarcoFalke)
face2519fa bitcoin-tx: Reject + sign in vout parsing (MarcoFalke)
fa8acaf0b9 bitcoin-tx: Reject + sign in replaceable parsing (MarcoFalke)
faff25a558 bitcoin-tx: Reject + sign in locktime (MarcoFalke)
dddd9e5fe3 bitcoin-tx: Reject + sign in nversion parsing (MarcoFalke)
fab06ac037 rest: Use SAFE_CHARS_URI in SanitizeString error msg (MarcoFalke)
8888bb499d rest: Reject + sign in /blockhashbyheight/ (MarcoFalke)
fafd43c691 test: Reject + sign when parsing regtest deployment params (MarcoFalke)
fa123afa0e Reject + sign when checking -ipcfd (MarcoFalke)
fa479857ed Reject + sign in SplitHostPort (MarcoFalke)
fab4c2967d net: Reject + sign when parsing subnet mask (MarcoFalke)
fa89652e68 init: Reject + sign in -*port parsing (MarcoFalke)
fa9c45577d cli: Reject + sign in -netinfo level parsing (MarcoFalke)
fa98041325 refactor: Use ToIntegral in CreateFromDump (MarcoFalke)
fa23ed7fc2 refactor: Use ToIntegral in ParseHDKeypath (MarcoFalke)

Pull request description:

  The legacy int parsing is problematic, because it accepts the `+` sign for unsigned integers. In all cases this is either:

  * Useless, because the `+` sign was already rejected.
  * Erroneous and inconsistent, when third party parsers reject it. (C.f. https://github.com/bitcoin/bitcoin/pull/32365)
  * Confusing, because the `+` sign is  neither documented, nor can it be assumed to be present.

  Fix all issues by removing the legacy int parsing.

ACKs for top commit:
  stickies-v:
    re-ACK faf55fc80b
  brunoerg:
    code review ACK faf55fc80b

Tree-SHA512: a311ab6a58fe02a37741c1800feb3dcfad92377b4bfb61b433b2393f52ba89ef45d00940972b2767b213a3dd7b59e5e35d5b659c586eacdfe4e565a77b12b19f
2025-05-20 15:55:38 +01:00
..
rpc Merge bitcoin/bitcoin#32514: scripted-diff: Remove unused leading newline in RPC docs 2025-05-17 10:10:35 +01:00
test Merge bitcoin/bitcoin#32562: doc: remove // for ... comments 2025-05-20 09:28:46 +01:00
CMakeLists.txt build, wallet, doc: Remove BDB 2025-05-06 12:21:32 -07:00
coincontrol.cpp wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction 2023-12-08 17:12:19 -05:00
coincontrol.h [wallet, rpc]: add `max_tx_weight` to tx funding options 2024-06-27 15:31:21 +01:00
coinselection.cpp Remove unused variable assignment 2024-12-13 21:00:07 -06:00
coinselection.h Merge bitcoin/bitcoin#29523: Wallet: Add `max_tx_weight` to transaction funding options (take 2) 2024-07-17 18:27:59 -04:00
context.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
context.h interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes 2023-10-20 10:30:16 -04:00
crypter.cpp refactor: vector -> span in CCrypter 2024-08-28 19:09:51 +02:00
crypter.h wallet: refactor: introduce `CMasterKey::DEFAULT_DERIVE_ITERATIONS` constant 2025-01-27 18:11:05 +01:00
db.cpp build, wallet, doc: Remove BDB 2025-05-06 12:21:32 -07:00
db.h wallet: Remove unused db functions 2025-05-06 16:53:16 -07:00
dump.cpp refactor: Use ToIntegral in CreateFromDump 2025-05-15 19:34:08 +02:00
dump.h wallettool: Don't create CWallet when dumping DB 2023-12-19 16:54:06 -05:00
external_signer_scriptpubkeyman.cpp util: add TransactionError includes and namespace declarations 2024-05-16 10:16:08 -05:00
external_signer_scriptpubkeyman.h common: Add PSBTError enum 2024-05-16 10:16:08 -05:00
feebumper.cpp wallet, refactor: Convert uint256 to Txid in wallet 2025-05-07 16:17:19 +01:00
feebumper.h wallet, refactor: Convert uint256 to Txid in wallet 2025-05-07 16:17:19 +01:00
fees.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
fees.h Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
init.cpp build, wallet, doc: Remove BDB 2025-05-06 12:21:32 -07:00
interfaces.cpp Merge bitcoin/bitcoin#30221: wallet: Ensure best block matches wallet scan state 2025-05-19 15:50:51 -04:00
load.cpp wallet: Remove unnecessary database Close step on shutdown 2025-05-14 11:03:57 -07:00
load.h wallet: Remove unnecessary database Close step on shutdown 2025-05-14 11:03:57 -07:00
migrate.cpp doc: remove For ... comments 2025-05-19 16:40:33 +01:00
migrate.h wallet: Remove unused db functions 2025-05-06 16:53:16 -07:00
receive.cpp wallet, refactor: Convert uint256 to Txid in wallet 2025-05-07 16:17:19 +01:00
receive.h wallet, refactor: Convert uint256 to Txid in wallet 2025-05-07 16:17:19 +01:00
scriptpubkeyman.cpp Remove unused LegacyDataSPKM::HaveWatchOnly() 2025-05-13 09:31:25 +02:00
scriptpubkeyman.h Remove unused LegacyDataSPKM::HaveWatchOnly() 2025-05-13 09:31:25 +02:00
spend.cpp wallet, refactor: Convert uint256 to Txid in wallet 2025-05-07 16:17:19 +01:00
spend.h doc: remove For ... comments 2025-05-19 16:40:33 +01:00
sqlite.cpp wallet: Remove unused db functions 2025-05-06 16:53:16 -07:00
sqlite.h wallet: Remove unused db functions 2025-05-06 16:53:16 -07:00
transaction.cpp scripted-diff: wallet: s/TxStateConflicted/TxStateBlockConflicted 2024-03-14 17:38:39 -04:00
transaction.h wallet: Drop unused fFromMe from CWalletTx 2025-05-14 11:23:22 -07:00
types.h scripted-diff: modernize outdated trait patterns - types 2025-02-21 10:41:27 +01:00
wallet.cpp Merge bitcoin/bitcoin#30221: wallet: Ensure best block matches wallet scan state 2025-05-19 15:50:51 -04:00
wallet.h Merge bitcoin/bitcoin#30221: wallet: Ensure best block matches wallet scan state 2025-05-19 15:50:51 -04:00
walletdb.cpp walletdb: Log the wallet version after it has been read from disk 2025-05-18 11:59:08 -07:00
walletdb.h wallet, refactor: Convert uint256 to Txid in wallet 2025-05-07 16:17:19 +01:00
wallettool.cpp Remove create options from wallet tool 2025-05-09 15:07:04 +02:00
wallettool.h Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
walletutil.cpp descriptors: Change Parse to return vector of descriptors 2024-08-08 12:47:22 -04:00
walletutil.h Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string 2024-08-28 15:56:15 +01:00