bitcoin/test/functional
Ava Chow 19b1e177d6
Merge bitcoin/bitcoin#32155: miner: timelock the coinbase to the mined block's height
a58cb3b1c1 qa: sanity check mined block have their coinbase timelocked to height (Antoine Poinsot)
8f2078af6a miner: timelock coinbase transactions (Antoine Poinsot)
788aeebf34 qa: use prev height as nLockTime for coinbase txs created in unit tests (Antoine Poinsot)
c76dbe9b8b qa: timelock coinbase transactions created in fuzz targets (Antoine Poinsot)
9c94069d8b contrib: timelock coinbase transactions in signet miner (Antoine Poinsot)
a5f52cfcc4 qa: timelock coinbase transactions created in functional tests (Antoine Poinsot)

Pull request description:

  The Consensus Cleanup soft fork proposal includes enforcing that coinbase transactions set their
  nLockTime field to the block height minus 1, as well as their nSequence such as to not disable the
  timelock. If such a fork were to be activated by Bitcoin users, miners need to be ready to produce
  compliant blocks at the risk of losing substantial amounts mining would-be invalid blocks. As miners
  are unfamously slow to upgrade, it's good to make this change as early as possible.

  Although Bitcoin Core's GBT implementation does not provide the `coinbasetxn` field, and mining
  pool software crafts the coinbase on its own, updating the Bitcoin Core mining code is a first step
  toward convincing pools to update their (often closed source) code. A possible followup is also to
  introduce new fields to GBT. In addition, this first step also makes it possible to test future
  Consensus Cleanup changes.

  The commit making the change also updates a bunch of seemingly-unrelated tests. This is because those tests were asserting error messages based on the txid of transactions involved, and changing the coinbase transaction structure necessarily changes the txid of all tests' transactions.

ACKs for top commit:
  Sjors:
    Code review ACK a58cb3b1c1
  achow101:
    ACK a58cb3b1c1
  TheCharlatan:
    Re-ACK a58cb3b1c1

Tree-SHA512: a2aae009a187eb760d34435f518a895ee76c6b02a667eb030ddf6bd584da6e8eae2737d974dbf81a928d60c07bcb4820f055adc067e18d8819640db0240bb513
2025-05-09 15:09:27 -07:00
..
data tests: Add BIP 373 test vectors 2025-04-17 16:31:57 -07:00
mocks wallet: return and display signer error 2024-04-16 17:47:43 +02:00
test_framework Merge bitcoin/bitcoin#32155: miner: timelock the coinbase to the mined block's height 2025-05-09 15:09:27 -07:00
.gitignore build: Remove Autotools-based build system 2024-08-30 21:31:39 +01:00
README.md scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
combine_logs.py refactor test: Cleaner combine_logs.py logic 2024-12-06 15:34:37 +01:00
combined_log_template.html
create_cache.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
example_test.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
feature_abortnode.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_addrman.py scripted-diff: Rename `PACKAGE_*` variables to `CLIENT_*` 2024-10-28 12:36:19 +00:00
feature_anchors.py test: Avoid F541 (f-string without any placeholders) 2024-12-05 08:39:09 +01:00
feature_asmap.py Fix nonsensical -noasmap behavior 2025-02-13 12:30:15 -05:00
feature_assumeutxo.py miner: timelock coinbase transactions 2025-04-25 12:44:08 -04:00
feature_assumevalid.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
feature_bind_extra.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_bind_port_discover.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
feature_bind_port_externalip.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_bip68_sequence.py test: Remove unused options and variables, correct comments 2025-05-06 12:33:16 -07:00
feature_block.py qa: timelock coinbase transactions created in functional tests 2025-04-25 12:44:08 -04:00
feature_blocksdir.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_blocksxor.py test: switch MiniWallet padding unit from weight to vsize 2024-09-28 22:49:41 +02:00
feature_cltv.py rpc: include verbose reject-details field in testmempoolaccept response 2024-12-04 14:37:37 -05:00
feature_coinstatsindex.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
feature_config_args.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
feature_csv_activation.py [validation] Make script error messages uniform for parallel/single validation 2024-12-02 16:25:17 -05:00
feature_dbcrash.py Merge bitcoin/bitcoin#29500: test: create assert_not_equal util 2025-04-01 13:52:41 -04:00
feature_dersig.py Merge bitcoin/bitcoin#28121: include verbose "reject-details" field in testmempoolaccept response 2025-01-03 07:03:23 -05:00
feature_dirsymlinks.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_discover.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_fastprune.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_fee_estimation.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
feature_filelock.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
feature_framework_miniwallet.py Merge bitcoin/bitcoin#30226: test: add validation for gettxout RPC response 2025-02-05 13:30:51 +00:00
feature_framework_startup_failures.py qa: Add feature_framework_startup_failures.py 2025-04-26 23:30:26 +02:00
feature_framework_unit_tests.py test: introduce output amount (de)compression routines 2025-03-04 12:50:17 -05:00
feature_help.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_includeconf.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_index_prune.py test: Avoid intermittent error in assert_equal(pruneheight_new, 248) 2024-12-13 11:06:17 +01:00
feature_init.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
feature_loadblock.py test: Avoid F541 (f-string without any placeholders) 2024-12-05 08:39:09 +01:00
feature_logging.py test: `-debug=0` and `-debug=none` behave similarly to `-nodebug` 2025-02-11 12:01:29 +01:00
feature_maxtipage.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_maxuploadtarget.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
feature_minchainwork.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
feature_notifications.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
feature_nulldummy.py [validation] Make script error messages uniform for parallel/single validation 2024-12-02 16:25:17 -05:00
feature_port.py test: add functional test for -port behavior 2024-11-15 16:05:32 -05:00
feature_posix_fs_permissions.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_presegwit_node_upgrade.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_proxy.py test: fix intermittent failures in feature_proxy.py 2024-07-30 10:52:53 -04:00
feature_pruning.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
feature_rbf.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
feature_reindex.py refactor: move read_xor_key() to TestNode 2024-08-25 08:42:38 -04:00
feature_reindex_readonly.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_remove_pruned_files_on_startup.py test: Check that reindex with prune wipes blk files 2025-01-22 08:52:04 +01:00
feature_segwit.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
feature_settings.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
feature_shutdown.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_signet.py test: avoid disk space warning for non-regtest 2025-03-15 16:07:07 +01:00
feature_startupnotify.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_taproot.py scripted-diff: adapt script error constant names in feature_taproot.py 2025-05-03 20:32:13 +02:00
feature_uacomment.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_unsupported_utxo_db.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
feature_utxo_set_hash.py miner: timelock coinbase transactions 2025-04-25 12:44:08 -04:00
feature_versionbits_warning.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
interface_bitcoin_cli.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
interface_http.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
interface_rest.py Add target to getblock(header) in RPC and REST 2025-01-22 12:04:02 +01:00
interface_rpc.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
interface_usdt_coinselection.py Merge bitcoin/bitcoin#31250: wallet: Disable creating and loading legacy wallets 2025-04-25 13:11:24 +01:00
interface_usdt_mempool.py scripted-diff: Use bpf_cflags 2025-04-24 10:47:57 +02:00
interface_usdt_net.py scripted-diff: Use bpf_cflags 2025-04-24 10:47:57 +02:00
interface_usdt_utxocache.py scripted-diff: Use bpf_cflags 2025-04-24 10:47:57 +02:00
interface_usdt_validation.py scripted-diff: Use bpf_cflags 2025-04-24 10:47:57 +02:00
interface_zmq.py Merge bitcoin/bitcoin#30893: test: Introduce ensure_for helper 2024-11-19 13:56:20 -05:00
mempool_accept.py qa: Wait for txindex to avoid race condition 2025-03-10 15:24:16 +01:00
mempool_accept_wtxid.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
mempool_compatibility.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
mempool_datacarrier.py test: Avoid F541 (f-string without any placeholders) 2024-12-05 08:39:09 +01:00
mempool_dust.py func: cleanup test_dustrelay comments 2024-11-20 13:44:49 -05:00
mempool_ephemeral_dust.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
mempool_expiry.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
mempool_limit.py functional test: Additional package evaluation coverage 2024-10-25 09:22:57 -04:00
mempool_package_limits.py test: switch MiniWallet padding unit from weight to vsize 2024-09-28 22:49:41 +02:00
mempool_package_onemore.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
mempool_package_rbf.py miner: timelock coinbase transactions 2025-04-25 12:44:08 -04:00
mempool_packages.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
mempool_persist.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
mempool_reorg.py scripted-diff: Rename lazily initialized bloom filters 2024-07-31 13:23:46 +01:00
mempool_resurrect.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
mempool_sigoplimit.py test: [refactor] Fix F841 flake8 2024-08-29 07:01:54 +02:00
mempool_spend_coinbase.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
mempool_truc.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
mempool_unbroadcast.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
mempool_updatefromblock.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
mining_basic.py qa: sanity check mined block have their coinbase timelocked to height 2025-04-25 12:44:08 -04:00
mining_getblocktemplate_longpoll.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
mining_mainnet.py qa: timelock coinbase transactions created in functional tests 2025-04-25 12:44:08 -04:00
mining_prioritisetransaction.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
p2p_1p1c_network.py test: fix intermittent timeout in p2p_1p1c_network.py 2025-01-29 10:46:55 -05:00
p2p_add_connections.py Merge bitcoin/bitcoin#30463: qa: Functional test improvements 2024-07-22 12:08:32 +01:00
p2p_addr_relay.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_addrfetch.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_addrv2_relay.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_block_sync.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_blockfilters.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
p2p_blocksonly.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_compactblocks.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
p2p_compactblocks_blocksonly.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_compactblocks_hb.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_disconnect_ban.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_dns_seeds.py test: avoid generating non-loopback traffic from p2p_dns_seeds.py 2025-01-14 09:21:24 +01:00
p2p_eviction.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_feefilter.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_filter.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_fingerprint.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_getaddr_caching.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
p2p_getdata.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_handshake.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
p2p_headers_sync_with_minchainwork.py test: Avoid intermittent timeout in p2p_headers_sync_with_minchainwork.py 2024-08-30 12:01:18 +02:00
p2p_i2p_ports.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_i2p_sessions.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_ibd_stalling.py test: fix intermittent timeout in p2p_ibd_stalling.py 2025-03-26 13:22:07 -04:00
p2p_ibd_txrelay.py test: fixes p2p_ibd_txrelay wait time 2025-01-29 14:24:29 -05:00
p2p_initial_headers_sync.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_invalid_block.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
p2p_invalid_locator.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_invalid_messages.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_invalid_tx.py [test] A non-standard transaction which is also consensus-invalid should return the consensus error 2024-10-17 10:58:42 +01:00
p2p_leak.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_leak_tx.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_message_capture.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_mutated_blocks.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_net_deadlock.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_nobloomfilter_messages.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_node_network_limited.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_opportunistic_1p1c.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_orphan_handling.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
p2p_outbound_eviction.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_permissions.py test: Add explicit onion bind to p2p_permissions 2024-09-10 16:32:08 -04:00
p2p_ping.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
p2p_seednode.py test: avoid generating non-loopback traffic from p2p_seednode.py 2025-01-14 09:20:58 +01:00
p2p_segwit.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
p2p_sendheaders.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_sendtxrcncl.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
p2p_timeouts.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_tx_download.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_tx_privacy.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_unrequested_blocks.py scripted-diff: test: Rename send_message to send_without_ping 2025-03-14 12:45:20 +01:00
p2p_v2_encrypted.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
p2p_v2_misbehaving.py net: additional disconnection logging 2024-11-26 13:22:55 +01:00
p2p_v2_transport.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
rpc_bind.py fix: handle invalid rpcbind port earlier 2024-09-17 21:47:29 -04:00
rpc_blockchain.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
rpc_createmultisig.py test: Run multisig script limit test 2025-05-06 12:33:16 -07:00
rpc_decodescript.py test: add P2A coverage for decodescript 2024-07-30 14:06:58 -04:00
rpc_deprecated.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
rpc_deriveaddresses.py Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string 2024-08-28 15:56:15 +01:00
rpc_dumptxoutset.py miner: timelock coinbase transactions 2025-04-25 12:44:08 -04:00
rpc_estimatefee.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
rpc_generate.py test: generateblocks called by multiple threads 2024-12-25 10:29:34 +01:00
rpc_getblockfilter.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
rpc_getblockfrompeer.py miner: timelock coinbase transactions 2025-04-25 12:44:08 -04:00
rpc_getblockstats.py test: add coverage to getblock and getblockstats 2024-09-13 10:50:49 -04:00
rpc_getchaintips.py test: add test for getchaintips behavior with invalid chains 2024-09-17 11:40:36 -04:00
rpc_getdescriptoractivity.py test: Call generate through test framework only 2024-12-06 08:20:52 +01:00
rpc_getdescriptorinfo.py test: `getdescriptorinfo`/`importdescriptors` with whitespace in pubkeys 2025-02-24 09:57:22 -03:00
rpc_help.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
rpc_invalid_address_message.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
rpc_invalidateblock.py validation: mark blocks building on an invalid block as BLOCK_FAILED_CHILD 2024-09-17 11:40:36 -04:00
rpc_mempool_info.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
rpc_misc.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
rpc_named_arguments.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
rpc_net.py test: avoid internet traffic in rpc_net.py 2024-11-22 18:28:07 +01:00
rpc_orphans.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
rpc_packages.py rpc: include verbose reject-details field in testmempoolaccept response 2024-12-04 14:37:37 -05:00
rpc_preciousblock.py test: create assert_not_equal util and add to where imports are needed 2025-04-01 08:39:24 -04:00
rpc_psbt.py test: Force named args for RPCOverloadWrapper optional args 2025-04-28 15:15:05 +02:00
rpc_rawtransaction.py test: Remove unused options and variables, correct comments 2025-05-06 12:33:16 -07:00
rpc_scanblocks.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
rpc_scantxoutset.py Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string 2024-08-28 15:56:15 +01:00
rpc_setban.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
rpc_signer.py qa: Use `sys.executable` when invoking other Python scripts 2024-12-19 17:10:20 +00:00
rpc_signmessagewithprivkey.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
rpc_signrawtransactionwithkey.py Remove second node since only 1 is needed for the test 2024-08-27 19:00:37 -03:00
rpc_txoutproof.py qa: Wait for txindex to avoid race condition 2025-03-10 15:24:16 +01:00
rpc_uptime.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
rpc_users.py test: -norpccookiefile 2024-12-03 10:38:21 +01:00
rpc_validateaddress.py test: P2A is a destination type with an address 2024-08-02 13:03:06 -04:00
rpc_whitelist.py test: Add coverage for rpcwhitelistdefault when unset 2025-04-01 15:11:15 +03:00
test-shell.md test: fix TestShell initialization and reset() 2025-02-20 15:25:43 +03:00
test_runner.py Merge bitcoin/bitcoin#30660: qa: Verify clean shutdown on startup failure 2025-05-08 16:57:46 -04:00
tool_bitcoin_chainstate.py test: Add functional test for bitcoin-chainstate 2025-03-26 15:05:17 +01:00
tool_signet_miner.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
tool_utxo_to_sqlite.py test: add test for utxo-to-sqlite conversion script 2024-12-28 02:38:57 +01:00
tool_wallet.py Remove create options from wallet tool 2025-05-09 15:07:04 +02:00
wallet_abandonconflict.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_address_types.py test: Force named args for RPCOverloadWrapper optional args 2025-04-28 15:15:05 +02:00
wallet_assumeutxo.py miner: timelock coinbase transactions 2025-04-25 12:44:08 -04:00
wallet_avoid_mixing_output_types.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_avoidreuse.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_backup.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_backwards_compatibility.py test: Use the correct node for doubled keypath test 2025-04-28 14:44:17 -07:00
wallet_balance.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_basic.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_blank.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_bumpfee.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_change_address.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_coinbase_category.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_conflicts.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_create_tx.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_createwallet.py test: Remove unused options and variables, correct comments 2025-05-06 12:33:16 -07:00
wallet_createwalletdescriptor.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_crosschain.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_descriptor.py test: rpcs disabled for descriptor wallets will be removed 2025-05-06 12:33:16 -07:00
wallet_disable.py scripted-diff: Add `__file__` argument to `BitcoinTestFramework.init()` 2024-07-16 22:06:47 +01:00
wallet_encryption.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_fallbackfee.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_fast_rescan.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_fundrawtransaction.py test: Force named args for RPCOverloadWrapper optional args 2025-04-28 15:15:05 +02:00
wallet_gethdkeys.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_groups.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_hd.py test: Remove unused options and variables, correct comments 2025-05-06 12:33:16 -07:00
wallet_importdescriptors.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_importprunedfunds.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_keypool.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_keypool_topup.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_labels.py test: Force named args for RPCOverloadWrapper optional args 2025-04-28 15:15:05 +02:00
wallet_listdescriptors.py wallet: Disallow creating legacy wallets 2025-04-23 12:11:56 -07:00
wallet_listreceivedby.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_listsinceblock.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_listtransactions.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_migration.py test: Remove unused options and variables, correct comments 2025-05-06 12:33:16 -07:00
wallet_miniscript.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_miniscript_decaying_multisig_descriptor_psbt.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_multisig_descriptor_psbt.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_multiwallet.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_orphanedreward.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_reindex.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_reorgsrestore.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_rescan_unconfirmed.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_resendwallettransactions.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_send.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_sendall.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_sendmany.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_signer.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_signmessagewithaddress.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_signrawtransactionwithwallet.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_simulaterawtx.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_spend_unconfirmed.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_startup.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_taproot.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_timelock.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_transactiontime_rescan.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_txn_clone.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00
wallet_txn_doublespend.py test: remove legacy wallet functional tests 2025-04-23 12:10:30 -07:00

README.md

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Assuming the build directory is build, running build/test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports.
  • If more than one name from a module is needed, use lexicographically sorted multi-line imports in order to reduce the possibility of potential merge conflicts.
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.
  • Use platform.system() for detecting the running operating system and os.name to check whether it's a POSIX system (see also the skip_if_platform_not_{linux,posix} methods in the BitcoinTestFramework class, which can be used to skip a whole test depending on the platform).

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_without_ping(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: