bitcoin/src
merge-script fad009af49
Merge bitcoin/bitcoin#32520: Remove legacy `Parse(U)Int*`
faf55fc80b doc: Remove ParseInt mentions in documentation (MarcoFalke)
3333282933 refactor: Remove unused Parse(U)Int* (MarcoFalke)
fa84e6c36c bitcoin-tx: Reject + sign in MutateTxDel* (MarcoFalke)
face2519fa bitcoin-tx: Reject + sign in vout parsing (MarcoFalke)
fa8acaf0b9 bitcoin-tx: Reject + sign in replaceable parsing (MarcoFalke)
faff25a558 bitcoin-tx: Reject + sign in locktime (MarcoFalke)
dddd9e5fe3 bitcoin-tx: Reject + sign in nversion parsing (MarcoFalke)
fab06ac037 rest: Use SAFE_CHARS_URI in SanitizeString error msg (MarcoFalke)
8888bb499d rest: Reject + sign in /blockhashbyheight/ (MarcoFalke)
fafd43c691 test: Reject + sign when parsing regtest deployment params (MarcoFalke)
fa123afa0e Reject + sign when checking -ipcfd (MarcoFalke)
fa479857ed Reject + sign in SplitHostPort (MarcoFalke)
fab4c2967d net: Reject + sign when parsing subnet mask (MarcoFalke)
fa89652e68 init: Reject + sign in -*port parsing (MarcoFalke)
fa9c45577d cli: Reject + sign in -netinfo level parsing (MarcoFalke)
fa98041325 refactor: Use ToIntegral in CreateFromDump (MarcoFalke)
fa23ed7fc2 refactor: Use ToIntegral in ParseHDKeypath (MarcoFalke)

Pull request description:

  The legacy int parsing is problematic, because it accepts the `+` sign for unsigned integers. In all cases this is either:

  * Useless, because the `+` sign was already rejected.
  * Erroneous and inconsistent, when third party parsers reject it. (C.f. https://github.com/bitcoin/bitcoin/pull/32365)
  * Confusing, because the `+` sign is  neither documented, nor can it be assumed to be present.

  Fix all issues by removing the legacy int parsing.

ACKs for top commit:
  stickies-v:
    re-ACK faf55fc80b
  brunoerg:
    code review ACK faf55fc80b

Tree-SHA512: a311ab6a58fe02a37741c1800feb3dcfad92377b4bfb61b433b2393f52ba89ef45d00940972b2767b213a3dd7b59e5e35d5b659c586eacdfe4e565a77b12b19f
2025-05-20 15:55:38 +01:00
..
bench Merge bitcoin/bitcoin#30221: wallet: Ensure best block matches wallet scan state 2025-05-19 15:50:51 -04:00
common doc: remove For ... comments 2025-05-19 16:40:33 +01:00
compat build: simplify *ifaddr handling 2025-05-08 16:49:58 +01:00
consensus Merge bitcoin/bitcoin#29039: versionbits refactoring 2025-04-29 14:06:45 -07:00
crc32c Update crc32c subtree to latest upstream master 2024-02-27 18:28:19 +00:00
crypto doc: remove For ... comments 2025-05-19 16:40:33 +01:00
index doc: remove For ... comments 2025-05-19 16:40:33 +01:00
init refactor: Avoid using IsArgSet() on -debug, -loglevel, and -vbparams list options 2025-02-13 12:30:15 -05:00
interfaces doc: remove For ... comments 2025-05-19 16:40:33 +01:00
ipc Reject + sign when checking -ipcfd 2025-05-15 22:12:15 +02:00
kernel doc: Adjust stale MSVC bug url 2025-05-19 12:30:56 +02:00
leveldb Update leveldb subtree to latest upstream 2025-05-16 12:39:59 +01:00
logging scripted-diff: modernize outdated trait patterns - values 2025-02-21 10:43:01 +01:00
minisketch Update minisketch subtree to latest upstream 2025-05-13 18:07:47 +01:00
node doc: add & amend copyright headers 2025-05-20 09:43:21 +01:00
policy fees: document non-monotonic estimation edge case 2025-05-06 09:50:43 +01:00
primitives tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00
qt Merge bitcoin/bitcoin#32562: doc: remove // for ... comments 2025-05-20 09:28:46 +01:00
rpc Merge bitcoin/bitcoin#32562: doc: remove // for ... comments 2025-05-20 09:28:46 +01:00
script Remove unused IsSingleKey 2025-05-09 15:06:51 +02:00
secp256k1 Update secp256k1 subtree to latest master 2025-05-13 11:31:34 +01:00
support doc: remove For ... comments 2025-05-19 16:40:33 +01:00
test Merge bitcoin/bitcoin#32520: Remove legacy `Parse(U)Int*` 2025-05-20 15:55:38 +01:00
univalue doc: add & amend copyright headers 2025-05-20 09:43:21 +01:00
util Merge bitcoin/bitcoin#32520: Remove legacy `Parse(U)Int*` 2025-05-20 15:55:38 +01:00
wallet Merge bitcoin/bitcoin#32520: Remove legacy `Parse(U)Int*` 2025-05-20 15:55:38 +01:00
zmq scripted-diff: Remove unused leading newline in RPC docs 2025-05-15 15:28:11 +02:00
.clang-format refactor: Print verbose serialize compiler error messages 2023-12-15 15:20:54 +01:00
.clang-tidy tidy: add clang-tidy `modernize-use-starts-ends-with` check 2024-09-14 20:33:32 +03:00
CMakeLists.txt cmake: Add application manifests when cross-compiling for Windows 2025-05-15 13:57:57 +01:00
addrdb.cpp scripted-diff: Rename `PACKAGE_*` variables to `CLIENT_*` 2024-10-28 12:36:19 +00:00
addrdb.h
addresstype.cpp policy: Add OP_1 <0x4e73> as a standard output type 2024-07-30 14:06:58 -04:00
addresstype.h refactor: deduplicate anchor witness program bytes (`0x4e,0x73`) 2025-03-23 21:58:39 +01:00
addrman.cpp addrman: cap the `max_pct` to not exceed the maximum number of addresses 2024-11-11 12:47:53 -03:00
addrman.h addrman: cap the `max_pct` to not exceed the maximum number of addresses 2024-11-11 12:47:53 -03:00
addrman_impl.h Merge bitcoin/bitcoin#30568: addrman: change internal id counting to int64_t 2024-09-20 12:55:22 -04:00
arith_uint256.cpp Add a fuzz test for Num3072 multiplication and inversion 2025-01-09 10:11:46 -05:00
arith_uint256.h arith_uint256: modernize comparison operators 2025-04-07 10:45:13 -04:00
attributes.h
banman.cpp refactor: Delay translation of _() literals 2025-01-14 19:21:37 +01:00
banman.h doc: remove For ... comments 2025-05-19 16:40:33 +01:00
base58.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
base58.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
bech32.cpp Split out bech32 separator char to header 2024-10-19 18:49:53 +02:00
bech32.h Split out bech32 separator char to header 2024-10-19 18:49:53 +02:00
bip324.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
bip324.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
bitcoin-chainstate.cpp Remove checkpoints 2025-03-13 11:13:13 +00:00
bitcoin-cli-res.rc scripted-diff: Rename `PACKAGE_*` variables to `CLIENT_*` 2024-10-28 12:36:19 +00:00
bitcoin-cli.cpp cli: Reject + sign in -netinfo level parsing 2025-05-15 19:48:38 +02:00
bitcoin-tx-res.rc scripted-diff: Rename `PACKAGE_*` variables to `CLIENT_*` 2024-10-28 12:36:19 +00:00
bitcoin-tx.cpp bitcoin-tx: Reject + sign in MutateTxDel* 2025-05-17 09:36:25 +02:00
bitcoin-util-res.rc scripted-diff: Rename `PACKAGE_*` variables to `CLIENT_*` 2024-10-28 12:36:19 +00:00
bitcoin-util.cpp refactor: Use TranslateFn type consistently 2025-01-15 12:15:40 +01:00
bitcoin-wallet-res.rc scripted-diff: Rename `PACKAGE_*` variables to `CLIENT_*` 2024-10-28 12:36:19 +00:00
bitcoin-wallet.cpp Remove create options from wallet tool 2025-05-09 15:07:04 +02:00
bitcoind-res.rc scripted-diff: Rename `PACKAGE_*` variables to `CLIENT_*` 2024-10-28 12:36:19 +00:00
bitcoind.cpp refactor: introduce a more general LockDirectories for init 2025-01-16 21:06:21 +00:00
blockencodings.cpp scripted-diff: LogPrint -> LogDebug 2024-08-29 13:49:57 +02:00
blockencodings.h tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00
blockfilter.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
blockfilter.h
chain.cpp
chain.h Remove checkpoints 2025-03-13 11:13:13 +00:00
chainparams.cpp test: Reject + sign when parsing regtest deployment params 2025-05-15 22:12:24 +02:00
chainparams.h
chainparamsbase.cpp net, init: derive default onion port if a user specified a -port 2024-11-14 13:41:02 -05:00
chainparamsbase.h net, init: derive default onion port if a user specified a -port 2024-11-14 13:41:02 -05:00
chainparamsseeds.h seeds: update fixed dns seeds 2025-03-06 15:39:58 -06:00
checkqueue.h Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor 2024-12-03 18:02:37 -05:00
clientversion.cpp doc: update MIT license URL 2025-05-20 09:30:41 +01:00
clientversion.h scripted-diff: Clarify "user agent" variable name 2024-10-28 12:35:49 +00:00
cluster_linearize.h clusterlin: add GetConnectedComponent 2025-03-27 15:48:44 -04:00
coins.cpp Merge bitcoin/bitcoin#30906: refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests 2024-12-04 14:09:05 -05:00
coins.h coins, refactor: Remove direct GetFlags access 2024-12-02 13:52:34 +01:00
compressor.cpp
compressor.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
core_io.h rpc: add getdescriptoractivity 2024-11-26 20:47:08 -05:00
core_memusage.h
core_read.cpp refactor: starts/ends_with changes for clang-tidy 20 2025-04-22 13:16:54 +01:00
core_write.cpp refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
cuckoocache.h doc: remove For ... comments 2025-05-19 16:40:33 +01:00
dbwrapper.cpp refactor: Remove manual CDBBatch size estimation 2025-04-07 15:59:41 +02:00
dbwrapper.h refactor: Remove manual CDBBatch size estimation 2025-04-07 15:59:41 +02:00
deploymentinfo.cpp scripted-diff: rename gbt_force and gbt_force_name 2025-04-30 14:51:21 +02:00
deploymentinfo.h scripted-diff: rename gbt_force and gbt_force_name 2025-04-30 14:51:21 +02:00
deploymentstatus.cpp scripted-diff: modernize outdated trait patterns - types 2025-02-21 10:41:27 +01:00
deploymentstatus.h versionbits: Simplify VersionBitsCache API 2025-01-21 00:38:03 +10:00
dummywallet.cpp build, wallet, doc: Remove BDB 2025-05-06 12:21:32 -07:00
external_signer.cpp refactor: Remove Span operator==, Use std::ranges::equal 2024-08-13 07:44:31 +02:00
external_signer.h
flatfile.cpp scripted-diff: LogPrint -> LogDebug 2024-08-29 13:49:57 +02:00
flatfile.h refactor: Add FlatFileSeq member variables in BlockManager 2024-07-24 09:39:35 +02:00
hash.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
hash.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
headerssync.cpp [headerssync] update headerssync config for v29 2025-03-04 14:23:18 -05:00
headerssync.h doc: remove For ... comments 2025-05-19 16:40:33 +01:00
httprpc.cpp rpc: Avoid join-split roundtrip for user:pass for auth credentials 2025-05-09 17:07:28 +02:00
httprpc.h
httpserver.cpp doc: remove For ... comments 2025-05-19 16:40:33 +01:00
httpserver.h rpc: increase the defaults for -rpcthreads and -rpcworkqueue 2024-11-04 17:08:21 +01:00
i2p.cpp refactor: starts/ends_with changes for clang-tidy 20 2025-04-22 13:16:54 +01:00
i2p.h i2p: log errors properly according to their severity 2024-06-12 16:19:50 -03:00
indirectmap.h
init.cpp Merge bitcoin/bitcoin#32520: Remove legacy `Parse(U)Int*` 2025-05-20 15:55:38 +01:00
init.h refactor: introduce a more general LockDirectories for init 2025-01-16 21:06:21 +00:00
key.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
key.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
key_io.cpp key: clear out secret data in `DecodeExtKey` 2024-10-27 15:38:54 +01:00
key_io.h
logging.cpp log: Enforce trailing newline, Remove redundant m_started_new_line 2024-10-01 11:31:39 +02:00
logging.h log: Enforce trailing newline, Remove redundant m_started_new_line 2024-10-01 11:31:39 +02:00
mapport.cpp mapport: make ProcessPCP void 2024-11-04 14:19:40 -05:00
mapport.h mapport: rename 'use_pcp' to 'enable' 2024-10-29 11:58:51 -04:00
memusage.h memusage: Add DynamicUsage for std::string 2024-11-04 18:46:40 +01:00
merkleblock.cpp [clang-tidy] Enable the misc-no-recursion check 2024-04-07 14:04:45 +01:00
merkleblock.h tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00
net.cpp net: drop win32 ifdef 2025-05-19 13:45:04 +01:00
net.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
net_permissions.cpp util: move fees.h and error.h to common/messages.h 2024-05-16 10:16:08 -05:00
net_permissions.h scripted-diff: modernize outdated trait patterns - types 2025-02-21 10:41:27 +01:00
net_processing.cpp Use LogBlockHeader for compact blocks 2025-04-15 08:04:50 -04:00
net_processing.h refactor: Fix net_processing iwyu includes 2024-11-13 14:09:58 +01:00
net_types.cpp rpc: avoid copying into UniValue 2024-05-20 16:48:19 +00:00
net_types.h tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00
netaddress.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
netaddress.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
netbase.cpp net: Reject + sign when parsing subnet mask 2025-05-15 22:11:52 +02:00
netbase.h net: Rename `_randomize_credentials` Proxy parameter to `tor_stream_isolation` 2025-04-01 20:18:59 +02:00
netgroup.cpp Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check 2023-12-06 11:22:42 -05:00
netgroup.h net: Add continuous ASMap health check logging 2023-12-02 22:03:08 +01:00
netmessagemaker.h refactor: NetMsg::Make() without nVersion 2023-11-20 14:02:27 +01:00
noui.cpp node: Use log levels in noui_ThreadSafeMessageBox 2024-03-21 16:41:16 +01:00
noui.h
outputtype.cpp remove unused GetDestinationForKey 2025-05-15 14:59:03 +02:00
outputtype.h remove unused GetDestinationForKey 2025-05-15 14:59:03 +02:00
pow.cpp fuzz: enable running fuzz test cases in Debug mode 2025-04-22 17:11:24 +10:00
pow.h consensus: add DeriveTarget() to pow.h 2025-01-22 11:29:05 +01:00
prevector.h refactor: Remove UB in prevector reverse iterators 2025-05-14 09:35:32 +02:00
protocol.cpp scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp} 2024-10-26 23:44:15 +02:00
protocol.h scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp} 2024-10-26 23:44:15 +02:00
psbt.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
psbt.h psbt: Implement un/ser of musig2 fields 2025-04-17 16:31:57 -07:00
pubkey.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
pubkey.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
random.cpp Remove support for RNDR/RNDRRS for aarch64 on Linux 2025-04-11 08:11:41 +02:00
random.h Merge bitcoin/bitcoin#31519: refactor: Use std::span over Span 2025-03-20 13:41:54 +08:00
randomenv.cpp build: simplify *ifaddr handling 2025-05-08 16:49:58 +01:00
randomenv.h
rest.cpp rest: Use SAFE_CHARS_URI in SanitizeString error msg 2025-05-17 08:59:19 +02:00
rest.h
scheduler.cpp scripted-diff: Rename SingleThreadedSchedulerClient to SerialTaskRunner 2024-02-15 14:43:14 +01:00
scheduler.h kernel: Remove dependency on CScheduler 2024-02-16 17:12:52 +01:00
serialize.h refactor: re-enable UBSan implicit-sign-change in serialize.h 2025-05-14 15:41:20 +02:00
signet.cpp scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
signet.h
span.h scripted-diff: Bump copyright headers after std::span changes 2025-03-12 19:46:54 +01:00
streams.cpp optimization: bulk serialization writes in `WriteBlockUndo` and `WriteBlock` 2025-04-14 12:04:06 +02:00
streams.h optimization: bulk serialization writes in `WriteBlockUndo` and `WriteBlock` 2025-04-14 12:04:06 +02:00
sync.cpp scripted-diff: modernize outdated trait patterns - values 2025-02-21 10:43:01 +01:00
sync.h tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00
threadsafety.h tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00
tinyformat.h refactor: Introduce struct to hold a runtime format string 2025-01-15 12:16:08 +01:00
torcontrol.cpp torcontrol: Fix addrOnion outdate comment 2025-04-16 19:59:52 +08:00
torcontrol.h net, init: derive default onion port if a user specified a -port 2024-11-14 13:41:02 -05:00
txdb.cpp refactor: Remove manual CDBBatch size estimation 2025-04-07 15:59:41 +02:00
txdb.h kernel: Move default cache constants to caches 2025-01-15 15:44:55 +01:00
txgraph.cpp txgraph: Special-case singletons in chunk index (optimization) 2025-05-12 17:07:30 -04:00
txgraph.h txgraph: Introduce TxGraph::GetWorstMainChunk (feature) 2025-05-12 17:07:30 -04:00
txmempool.cpp txmempool: fix typos in comments 2024-12-31 00:04:20 -03:00
txmempool.h txmempool: fix typos in comments 2024-12-31 00:04:20 -03:00
txorphanage.cpp [fuzz] TxOrphanage::SanityCheck accounting 2025-02-07 13:55:57 -05:00
txorphanage.h [fuzz] TxOrphanage::SanityCheck accounting 2025-02-07 13:55:57 -05:00
txrequest.cpp [refactor] make GetCandidatePeers take uint256 and in-out vector 2025-01-29 18:05:16 -05:00
txrequest.h doc: remove For ... comments 2025-05-19 16:40:33 +01:00
uint256.cpp refactor: Remove SetHexDeprecated 2025-04-09 15:59:59 +01:00
uint256.h refactor: Remove SetHexDeprecated 2025-04-09 15:59:59 +01:00
undo.h Include version.h in fewer places 2023-11-16 11:36:22 +10:00
validation.cpp Merge bitcoin/bitcoin#31624: doc: warn that CheckBlock() underestimates sigops 2025-05-14 10:05:41 -04:00
validation.h doc: remove For ... comments 2025-05-19 16:40:33 +01:00
validationinterface.cpp refactor: include the proper header rather than forward-declaring RemovalReasonToString 2024-10-08 15:25:47 +00:00
validationinterface.h doc: remove For ... comments 2025-05-19 16:40:33 +01:00
versionbits.cpp scripted-diff: rename gbt_force and gbt_force_name 2025-04-30 14:51:21 +02:00
versionbits.h scripted-diff: rename gbt_force and gbt_force_name 2025-04-30 14:51:21 +02:00
versionbits_impl.h tests: refactor versionbits fuzz test 2025-01-21 00:38:03 +10:00
walletinitinterface.h tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00