Moved auth system from nostr_core_lib back into ginxsom. Still debugging but so many changes I wanted to commit.

tests/auth_test.sh

@@ -52,72 +52,54 @@ record_test_result() {
     fi
 }
 
-echo "=== Ginxsom Authentication System Test Suite ==="
-echo "Testing unified nostr_core_lib authentication integration"
-echo "Timestamp: $(date -Iseconds)"
-echo
-
 # Check prerequisites
-echo "[INFO] Checking prerequisites..."
 for cmd in nak curl jq sqlite3; do
     if ! command -v $cmd &> /dev/null; then
-        echo "[ERROR] $cmd command not found"
+        echo "$cmd command not found"
         exit 1
     fi
 done
 
 # Check if server is running
 if ! curl -s -f "${SERVER_URL}/" > /dev/null 2>&1; then
-    echo "[ERROR] Server not running at $SERVER_URL"
-    echo "[INFO] Start with: ./restart-all.sh"
+    echo "Server not running at $SERVER_URL"
+    echo "Start with: ./restart-all.sh"
     exit 1
 fi
 
 # Check if database exists
 if [[ ! -f "$DB_PATH" ]]; then
-    echo "[ERROR] Database not found at $DB_PATH"
+    echo "Database not found at $DB_PATH"
     exit 1
 fi
 
-echo "[SUCCESS] All prerequisites met"
-echo
-
 # Setup test environment and auth rules ONCE at the beginning
-echo "=== Setting up authentication rules ==="
 mkdir -p "$TEST_DIR"
 
 # Enable authentication rules
 sqlite3 "$DB_PATH" "INSERT OR REPLACE INTO auth_config (key, value) VALUES ('auth_rules_enabled', 'true');"
 
 # Delete ALL existing auth rules and cache (clean slate)
-echo "Deleting all existing auth rules..."
 sqlite3 "$DB_PATH" "DELETE FROM auth_rules;"
 sqlite3 "$DB_PATH" "DELETE FROM auth_cache;"
 
 # Set up all test rules at once
-echo "Creating test auth rules..."
-
 # 1. Whitelist for TEST_USER1 for upload operations (priority 10)
-sqlite3 "$DB_PATH" "INSERT INTO auth_rules (rule_type, rule_target, operation, priority, enabled, description) 
-                   VALUES ('pubkey_whitelist', '$TEST_USER1_PUBKEY', 'upload', 10, 1, 'TEST_WHITELIST_USER1');"
+sqlite3 "$DB_PATH" "INSERT INTO auth_rules (rule_type, rule_target, operation, priority, enabled, description)
+                    VALUES ('pubkey_whitelist', '$TEST_USER1_PUBKEY', 'upload', 10, 1, 'TEST_WHITELIST_USER1');"
 
 # 2. Blacklist for TEST_USER2 for upload operations (priority 5 - higher priority)
-sqlite3 "$DB_PATH" "INSERT INTO auth_rules (rule_type, rule_target, operation, priority, enabled, description) 
-                   VALUES ('pubkey_blacklist', '$TEST_USER2_PUBKEY', 'upload', 5, 1, 'TEST_BLACKLIST_USER2');"
+sqlite3 "$DB_PATH" "INSERT INTO auth_rules (rule_type, rule_target, operation, priority, enabled, description)
+                    VALUES ('pubkey_blacklist', '$TEST_USER2_PUBKEY', 'upload', 5, 1, 'TEST_BLACKLIST_USER2');"
 
 # 3. Hash blacklist (will be set after we create a test file)
 echo "test content for hash blacklist" > "$TEST_DIR/blacklisted_file.txt"
 BLACKLISTED_HASH=$(sha256sum "$TEST_DIR/blacklisted_file.txt" | cut -d' ' -f1)
-sqlite3 "$DB_PATH" "INSERT INTO auth_rules (rule_type, rule_target, operation, priority, enabled, description) 
-                   VALUES ('hash_blacklist', '$BLACKLISTED_HASH', 'upload', 5, 1, 'TEST_HASH_BLACKLIST');"
-
-echo "Hash blacklisted: $BLACKLISTED_HASH"
+sqlite3 "$DB_PATH" "INSERT INTO auth_rules (rule_type, rule_target, operation, priority, enabled, description)
+                    VALUES ('hash_blacklist', '$BLACKLISTED_HASH', 'upload', 5, 1, 'TEST_HASH_BLACKLIST');"
 
 # Display the rules we created
-echo
-echo "Auth rules created:"
-sqlite3 "$DB_PATH" -header -column "SELECT rule_type, rule_target, operation, priority, enabled, description FROM auth_rules WHERE description LIKE 'TEST_%' ORDER BY priority;"
-echo
+# (Auth rules configured for testing)
 
 # Helper functions
 create_test_file() {
@@ -173,8 +155,6 @@ test_upload() {
 }
 
 # Run the tests
-echo "=== Running Authentication Tests ==="
-echo
 
 # Test 1: Whitelisted user (should succeed)
 test_file1=$(create_test_file "whitelisted_upload.txt" "Content from whitelisted user")
@@ -194,20 +174,15 @@ RANDOM_PRIVKEY="abcd1234567890abcd1234567890abcd1234567890abcd1234567890abcd1234
 test_upload "Test 4: Random User (No Rules)" "$RANDOM_PRIVKEY" "$test_file4" "ANY"
 
 # Test 5: Test with authentication disabled
-echo "=== Test 5: Authentication Disabled ==="
-echo "Disabling authentication rules..."
 sqlite3 "$DB_PATH" "INSERT OR REPLACE INTO auth_config (key, value) VALUES ('auth_rules_enabled', 'false');"
 
 test_file5=$(create_test_file "auth_disabled.txt" "Upload with auth disabled")
 test_upload "Test 5: Upload with Authentication Disabled" "$TEST_USER2_PRIVKEY" "$test_file5" "200"
 
 # Re-enable authentication
-echo "Re-enabling authentication rules..."
 sqlite3 "$DB_PATH" "INSERT OR REPLACE INTO auth_config (key, value) VALUES ('auth_rules_enabled', 'true');"
-echo
 
 # Test failure modes - comprehensive edge case testing
-echo "=== Test 6: Invalid Authorization Header Formats ==="
 
 # Helper function for failure mode tests
 test_failure_mode() {
@@ -242,7 +217,7 @@ test_failure_mode "Test 6b: Invalid Authorization Prefix" "Bearer invalidtoken12
 # Test 6c: Invalid Base64 in Authorization
 test_failure_mode "Test 6c: Invalid Base64 in Authorization" "Nostr invalid!@#base64"
 
-echo "=== Test 7: Malformed JSON Events ==="
+# Test malformed JSON events
 
 # Test 7a: Invalid JSON Structure
 malformed_json='{"kind":24242,"content":"","created_at":'  # Incomplete JSON
@@ -254,10 +229,9 @@ missing_fields_json='{"kind":24242,"content":"","created_at":1234567890,"tags":[
 missing_fields_b64=$(echo -n "$missing_fields_json" | base64 -w 0)
 test_failure_mode "Test 7b: Missing Required Fields (no pubkey)" "Nostr $missing_fields_b64"
 
-echo "=== Test 8: Invalid Key Formats ==="
+# Test invalid key formats
 
 # Test 8a: Short Public Key
-echo "Test 8a: Short Public Key (32 chars instead of 64)"
 echo "short_key_test" > "$TEST_DIR/short_key.txt"
 file_hash=$(sha256sum "$TEST_DIR/short_key.txt" | cut -d' ' -f1)
 short_pubkey="1234567890abcdef1234567890abcdef"  # 32 chars instead of 64