laantungir/nostr-tools
1
0
Fork 0
mirror of https://github.com/nbd-wtf/nostr-tools.git synced 2025-12-09 00:28:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix infinite loop bug caused by malformed TLVs on nip19.

Browse Source
This commit is contained in:
fiatjaf
2023-06-08 10:33:15 -03:00
parent bb5acfc197
commit 472a01af6a
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
nip19.ts
View File

@@ -69,9 +69,7 @@ export function decode(nip19: string): DecodeResult {
data: { data: {
id: bytesToHex(tlv[0][0]), id: bytesToHex(tlv[0][0]),
relays: tlv[1] ? tlv[1].map(d => utf8Decoder.decode(d)) : [], relays: tlv[1] ? tlv[1].map(d => utf8Decoder.decode(d)) : [],
author: tlv[2]?.[0] author: tlv[2]?.[0] ? bytesToHex(tlv[2][0]) : undefined
? bytesToHex(tlv[2][0])
: undefined
} }
} }
} }
@@ -123,9 +121,10 @@ function parseTLV(data: Uint8Array): TLV {
while (rest.length > 0) { while (rest.length > 0) {
let t = rest[0] let t = rest[0]
let l = rest[1] let l = rest[1]
if (!l) throw new Error(`malformed TLV ${t}`)
let v = rest.slice(2, 2 + l) let v = rest.slice(2, 2 + l)
rest = rest.slice(2 + l) rest = rest.slice(2 + l)
if (v.length < l) continue if (v.length < l) throw new Error(`not enough data to read on TLV ${t}`)
result[t] = result[t] || [] result[t] = result[t] || []
result[t].push(v) result[t].push(v)
} }

2
package.json
View File

@@ -1,6 +1,6 @@
{ {
"name": "nostr-tools", "name": "nostr-tools",
"version": "1.11.1", "version": "1.11.2",
"description": "Tools for making a Nostr client.", "description": "Tools for making a Nostr client.",
"repository": { "repository": {
"type": "git", "type": "git",