fix many bugs.

This commit is contained in:
fiatjaf
2021-02-23 00:17:22 -03:00
parent 710a3c3ce1
commit b7e33c512c
3 changed files with 38 additions and 33 deletions

View File

@@ -1,6 +1,6 @@
{ {
"name": "nostr-tools", "name": "nostr-tools",
"version": "0.4.1", "version": "0.4.2",
"description": "Tools for making a Nostr client.", "description": "Tools for making a Nostr client.",
"main": "index.js", "main": "index.js",
"repository": { "repository": {

28
pool.js
View File

@@ -15,13 +15,13 @@ export function relayPool(globalPrivateKey) {
const activeSubscriptions = {} const activeSubscriptions = {}
const sub = async (id, {cb, filter}) => { const sub = ({cb, filter}, id = Math.random().toString().slice(2)) => {
const subControllers = Object.fromEntries( const subControllers = Object.fromEntries(
Object.values(relays) Object.values(relays)
.filter(({policy}) => policy.read) .filter(({policy}) => policy.read)
.map(({relay}) => [ .map(({relay}) => [
relay.url, relay.url,
relay.sub({filter, cb: event => cb(event, relay)}) relay.sub({filter, cb: event => cb(event, relay.url)})
]) ])
) )
@@ -29,14 +29,16 @@ export function relayPool(globalPrivateKey) {
sub: ({cb = cb, filter = filter}) => sub: ({cb = cb, filter = filter}) =>
Object.entries(subControllers).map(([relayURL, sub]) => [ Object.entries(subControllers).map(([relayURL, sub]) => [
relayURL, relayURL,
sub(id, {cb, filter}) sub({cb, filter}, id)
]), ]),
addRelay: relay => { addRelay: relay => {
subControllers[relay.url] = relay.sub({cb, filter}) subControllers[relay.url] = relay.sub({cb, filter})
}, },
removeRelay: relayURL => { removeRelay: relayURL => {
subControllers[relayURL].unsub() if (relayURL in subControllers) {
if (Object.keys(subControllers).length === 0) unsub() subControllers[relayURL].unsub()
if (Object.keys(subControllers).length === 0) unsub()
}
}, },
unsub: () => { unsub: () => {
Object.values(subControllers).forEach(sub => sub.unsub()) Object.values(subControllers).forEach(sub => sub.unsub())
@@ -48,7 +50,7 @@ export function relayPool(globalPrivateKey) {
} }
return { return {
sub: sub.bind(null, Math.random()), sub,
relays, relays,
setPrivateKey(privateKey) { setPrivateKey(privateKey) {
globalPrivateKey = privateKey globalPrivateKey = privateKey
@@ -85,7 +87,7 @@ export function relayPool(globalPrivateKey) {
let index = noticeCallbacks.indexOf(cb) let index = noticeCallbacks.indexOf(cb)
if (index !== -1) noticeCallbacks.splice(index, 1) if (index !== -1) noticeCallbacks.splice(index, 1)
}, },
async publish(event, statusCallback) { async publish(event, statusCallback = (status, relayURL) => {}) {
if (!event.sig) { if (!event.sig) {
event.tags = event.tags || [] event.tags = event.tags || []
@@ -103,15 +105,9 @@ export function relayPool(globalPrivateKey) {
.filter(({policy}) => policy.write) .filter(({policy}) => policy.write)
.map(async ({relay}) => { .map(async ({relay}) => {
try { try {
await relay.publish(event) await relay.publish(event, status =>
statusCallback(0, relay.url) statusCallback(status, relay.url)
let {unsub} = relay.sub({ )
cb: () => {
statusCallback(1, relay.url)
},
filter: {id: event.id}
})
setTimeout(unsub, 5000)
} catch (err) { } catch (err) {
statusCallback(-1, relay.url) statusCallback(-1, relay.url)
} }

View File

@@ -1,7 +1,6 @@
import 'websocket-polyfill' import 'websocket-polyfill'
import {verifySignature} from './event' import {verifySignature} from './event'
import {sha256} from './utils'
export function normalizeRelayURL(url) { export function normalizeRelayURL(url) {
let [host, ...qs] = url.split('?') let [host, ...qs] = url.split('?')
@@ -59,11 +58,6 @@ export function relayConnect(url, onNotice) {
} }
if (data.length > 1) { if (data.length > 1) {
if (data === 'PING') {
ws.send('PONG')
return
}
if (data[0] === 'NOTICE') { if (data[0] === 'NOTICE') {
if (data.length < 2) return if (data.length < 2) return
@@ -83,10 +77,7 @@ export function relayConnect(url, onNotice) {
channels[channel](event) channels[channel](event)
} }
} else { } else {
console.warn( console.warn('got event with invalid signature from ' + url, event)
'got event with invalid signature from ' + url,
event
)
} }
return return
} }
@@ -115,13 +106,19 @@ export function relayConnect(url, onNotice) {
} }
} }
const sub = async ({ch, cb, filter}) => { const sub = ({cb, filter}, channel = Math.random().toString().slice(2)) => {
const channel = ch || (await sha256(Math.random().toString())).reduce((str, byte) => str + byte.toString(16).padStart(2, '0'), '') var filters = []
trySend(['REQ', channel, filter]) if (Array.isArray(filter)) {
filters = filter
} else {
filters.push(filter)
}
trySend(['REQ', channel, ...filters])
channels[channel] = cb channels[channel] = cb
return { return {
sub: ({cb = cb, filter = filter}) => sub({ch: channel, cb, filter}), sub: ({cb = cb, filter = filter}) => sub({cb, filter}, channel),
unsub: () => trySend(['CLOSE', channel]) unsub: () => trySend(['CLOSE', channel])
} }
} }
@@ -129,8 +126,20 @@ export function relayConnect(url, onNotice) {
return { return {
url, url,
sub, sub,
async publish(event) { async publish(event, statusCallback = status => {}) {
trySend(['EVENT', event]) try {
await trySend(['EVENT', event])
statusCallback(0)
let {unsub} = relay.sub({
cb: () => {
statusCallback(1)
},
filter: {id: event.id}
})
setTimeout(unsub, 5000)
} catch (err) {
statusCallback(-1)
}
}, },
close() { close() {
ws.close() ws.close()