From f87b2dbd8f0728e2256fa0f578ee0bc86ffb195d Mon Sep 17 00:00:00 2001
From: Laan Tungir <laantungir@laantungir.github.io>
Date: Sat, 27 Sep 2025 10:03:20 -0400
Subject: [PATCH] Version v0.3.15 - Change temp pad location to final
 destination for the pad

---
 otp-arm64  | Bin 107048 -> 107048 bytes
 otp-x86_64 | Bin 122128 -> 122128 bytes
 otp.c      |  46 +++++++++-------------------------------------
 3 files changed, 9 insertions(+), 37 deletions(-)

diff --git a/otp-arm64 b/otp-arm64
index d962bd7722ad38f34c4f1b71adede7f0608237cc..4bc2ec2da502c17ae5ef76e10d4d86728685c127 100755
GIT binary patch
delta 63
zcmZ2+gl)wUwhbvvB0*iEQ_F;HJ}C<9GxR77tU7f-qP4k#X?q0|<24aRlkNWEj1DS5
RdV)10yA+U~5z08h2LSCt6?Oms

delta 63
zcmZ2+gl)wUwhbvvB3~Wl*K>SyD?Gxkr7<IJ=CqhyGeepyn6_6iF<uj4G~Vtn&gh^5
Rq$gN2vP%K!8KI05d;l7I7GwYb

diff --git a/otp-x86_64 b/otp-x86_64
index d318cc69037b4ba35ba9537b835c08ed11e06e33..27a70d98984ddf63056ef2f4ff6143c9a226e868 100755
GIT binary patch
delta 63
zcmbQRi+#c__6-%xBAQo!?OgV@=-Z+tj0bD#mX<75cIs{JVcy=u%y=t=(PVpi1mjUf
SAgx=)m?Z(EXG~(O@B#p#;~GW)

delta 63
zcmbQRi+#c__6-%xB43)cuIleweX7u6o%i3KM^fI;cw?J;n78*ZGu{eeG~S*b!FW^=
RNb6QHW=R0)8Iu?*ya0Se8Grx)

diff --git a/otp.c b/otp.c
index 8e0c5bf..abcb181 100644
--- a/otp.c
+++ b/otp.c
@@ -405,7 +405,7 @@ int interactive_mode(void) {
 
 void show_main_menu(void) {
     printf("\n");
-    print_centered_header("Main Menu - OTP v0.3.13", 0);
+    print_centered_header("Main Menu - OTP v0.3.14", 0);
     printf("\n");
 
     printf(" \033[4mT\033[0mext encrypt\n");    //TEXT ENCRYPT
@@ -860,13 +860,13 @@ int generate_pad(uint64_t size_bytes, int display_progress) {
         return 1;
     }
     
-    char temp_filename[64];
+    char temp_filename[1024];
     char pad_path[MAX_HASH_LENGTH + 20];
     char state_path[MAX_HASH_LENGTH + 20];
     char chksum_hex[MAX_HASH_LENGTH];
     
-    // Create temporary filename
-    snprintf(temp_filename, sizeof(temp_filename), "temp_%ld.pad", time(NULL));
+    // Create temporary filename in the pads directory to avoid cross-filesystem issues
+    snprintf(temp_filename, sizeof(temp_filename), "%s/temp_%ld.pad", current_pads_dir, time(NULL));
     
     FILE* urandom = fopen("/dev/urandom", "rb");
     if (!urandom) {
@@ -936,39 +936,11 @@ int generate_pad(uint64_t size_bytes, int display_progress) {
     // Get final paths in pads directory
     get_pad_path(chksum_hex, pad_path, state_path);
     
-    // Try rename first (works for same filesystem)
+    // Rename temporary file to final name (atomic operation within same directory)
     if (rename(temp_filename, pad_path) != 0) {
-        // If rename fails, try copy and delete (works across filesystems)
-        FILE* temp_file = fopen(temp_filename, "rb");
-        FILE* dest_file = fopen(pad_path, "wb");
-        
-        if (!temp_file || !dest_file) {
-            printf("Error: Cannot copy pad file to pads directory\n");
-            if (temp_file) fclose(temp_file);
-            if (dest_file) fclose(dest_file);
-            unlink(temp_filename);
-            return 1;
-        }
-        
-        // Copy file in chunks
-        unsigned char copy_buffer[64 * 1024];
-        size_t bytes_read;
-        while ((bytes_read = fread(copy_buffer, 1, sizeof(copy_buffer), temp_file)) > 0) {
-            if (fwrite(copy_buffer, 1, bytes_read, dest_file) != bytes_read) {
-                printf("Error: Failed to copy pad file to pads directory\n");
-                fclose(temp_file);
-                fclose(dest_file);
-                unlink(temp_filename);
-                unlink(pad_path);
-                return 1;
-            }
-        }
-        
-        fclose(temp_file);
-        fclose(dest_file);
-        
-        // Remove temporary file after successful copy
+        printf("Error: Cannot rename temporary pad file to final name\n");
         unlink(temp_filename);
+        return 1;
     }
     
     // Set pad file to read-only
@@ -3825,7 +3797,7 @@ int generate_ascii_armor(const char* chksum, uint64_t offset, const unsigned cha
     strcpy(*ascii_output, "-----BEGIN OTP MESSAGE-----\n");
     
     char temp_line[256];
-    snprintf(temp_line, sizeof(temp_line), "Version: v0.3.13\n");
+    snprintf(temp_line, sizeof(temp_line), "Version: v0.3.14\n");
     strcat(*ascii_output, temp_line);
     
     snprintf(temp_line, sizeof(temp_line), "Pad-ChkSum: %s\n", chksum);
@@ -5567,7 +5539,7 @@ int handle_delete_pad(const char* pad_chksum) {
 
 
 void print_usage(const char* program_name) {
-    printf("OTP Cipher - One Time Pad Implementation v0.3.13\n");
+    printf("OTP Cipher - One Time Pad Implementation v0.3.14\n");
     printf("Built for testing entropy system\n");
     printf("Usage:\n");
     printf("  %s                                         - Interactive mode\n", program_name);